Messages in this thread | | | Date | Wed, 19 Mar 2014 15:05:57 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 15/19] perf, c2c: Add callchain support |
| |
On Wed, Mar 19, 2014 at 09:53:28AM -0400, Don Zickus wrote: > On Wed, Mar 19, 2014 at 02:00:35PM +0100, Jiri Olsa wrote: > > On Fri, Feb 28, 2014 at 12:43:04PM -0500, Don Zickus wrote: > > > > SNIP > > > > > > > > +static int > > > +opt_callchain_cb(const struct option *opt, const char *arg, int unset) > > > +{ > > > + struct perf_c2c *c2c = (struct perf_c2c *)opt->value; > > > + char *tok, *tok2; > > > + char *endptr; > > > > > > this still needs to be shared with report code, but > > I'm guessing V2 was about moving to hist_entry-ies > > I guess I don't understand this? I don't use the report code. Is there > another way I can get this?
opt_callchain_cb is same as parse_callchain_opt function, the argument parsing code could be shared
jirka
| |