Messages in this thread | | | Date | Fri, 28 Feb 2014 14:44:22 -0500 | From | Don Zickus <> | Subject | Re: [PATCH 11/19] perf, c2c: Add in sort on physid |
| |
On Fri, Feb 28, 2014 at 10:59:18AM -0800, Andi Kleen wrote: > Don Zickus <dzickus@redhat.com> writes: > > + > > + /* > > + * must pass period=weight in order to get the correct > > + * sorting from hists__collapse_resort() which is solely > > + * based on periods. We want sorting be done on nr_events * weight > > + * and this is indirectly achieved by passing period=weight here > > + * and the he_stat__add_period() function. > > + */ > > sort.c really must be fixed to support multiple sort keys properly. > Lots of other code has workarounds for this too (e.g. it is a bit > problem for TSX abort weights) > > I would suggest to fix that instead of hacking around it.
I don't think I understand the problem enough to know what to fix. I just copied this piece of code from builtin-report.c and things seemed to work.
Mind giving me some details and I can look at fixing it. :-)
Cheers, Don
| |