Messages in this thread | | | Date | Tue, 17 Jan 2012 16:44:45 +0800 | From | Li Zefan <> | Subject | Re: Updated btrfs/crypto snappy interface ready for merging |
| |
21:54, Chris Mason wrote: > On Thu, Jan 12, 2012 at 04:28:47PM -0800, Andi Kleen wrote: >> Here's a slightly updated version of the BTRFS snappy interface. >> snappy is a faster compression algorithm that provides similar >> compression as LZO, but generally better performance. > > Thanks Andi, I've queued this up to a btrfs snappy branch. I put the > commits against 3.2 instead of 3.3 though so people could try it out. > > The only problem I've hit is that snappy is failing xfstests number 135. > It's reproducible on an empty FS. Could you please take a look? >
It's because decompressing inline extents always fails. I've fixed it and will send the patch out in a new mail thread.
But seems there's bug in lib snappy code, which makes the decompressed data doesn't quite match the original data.
Simply copy a file to a btrfs filesystem with snappy enabled, and clear page cache, and check the file:
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; - * version 2.1 of the License (not later!) + * License as published by the Free ftwaware Foundation; + * version 2.1 of the censnse (not later!) * - * This program is distributed in the hope that it will be useful, + * is program i is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Lesser General Public License for more details. + * GNU Lesser General Publicicenense for more details. * * You should have received a copy of the GNU Lesser General Public - * License along with this program; if not, write to the Free Software + * License along withhis progogram; if not, write to theree e Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |