lkml.org 
[lkml]   [2011]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 14/19] OpenRISC: Module support
From
Date
On Sun, 19 Jun 2011 13:43:40 +0200, Jonas Bonn said:

Arnd already did a number of comments - two things I didn't see him note:

> arch/openrisc/kernel/module.c | 126 +++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 126 insertions(+), 0 deletions(-)
> create mode 100644 arch/openrisc/kernel/module.c
>
> diff --git a/arch/openrisc/kernel/module.c b/arch/openrisc/kernel/module.c
> new file mode 100644
> index 0000000..952b129
> --- /dev/null
> +++ b/arch/openrisc/kernel/module.c
> @@ -0,0 +1,126 @@
> +/*
> + * OpenRISC module.c

Lose the filenames in the headers - you do this in multiple files.

Also, do you even *need* a module.c? There isn't much in here, will the main
kernel/module.c do the work needed? Or did you end up with one because the
arch you cloned had one?

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-06-21 22:05    [W:0.271 / U:3.116 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site