Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 10/19] OpenRISC: System calls | Date | Sun, 19 Jun 2011 14:11:28 -0700 |
| |
Jonas Bonn <jonas@southpole.se> writes:
> On Sun, 2011-06-19 at 17:09 +0200, richard -rw- weinberger wrote: >> On Sun, Jun 19, 2011 at 1:43 PM, Jonas Bonn <jonas@southpole.se> wrote: >> > +asmlinkage int _sys_vfork(struct pt_regs *regs) >> > +{ >> > + /* This doesn't seem to work */ >> > +// return do_fork(CLONE_VFORK | CLONE_VM | SIGCHLD, regs->sp, regs, 0, NULL, NULL); >> >> Just being curious, why does that not work? > > Something about the CLONE_VM flag is breaking things... not sure what,
When "breaking" is a kernel oops or similar then you have a security hole because CLONE_VM can be specified directly by user space in clone()
So most likely you need to fix that anyways.
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |