Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [RFC Patch] virtio: export model and type in /sys | Date | Mon, 31 Jan 2011 14:35:24 +1030 |
| |
On Mon, 31 Jan 2011 01:23:00 pm Amerigo Wang wrote: > Our kdump script needs /sys/block/X/device/{vendor, model, type}, > but virtio devices don't have {model, type}, this patch adds them. > Actually, I don't know how to fill the model field, other block devices > seem read it from SCSI. Any comments?
This seems deeply wrong. Can't you fix your script?
Model might sanely map to the feature bits, but making the type the same as the PCI type is weird...
Confused, Rusty.
| |