lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC Patch] virtio: export model and type in /sys
    On Tue, Feb 01, 2011 at 12:37:38PM -0500, Christoph Hellwig wrote:
    > On Mon, Jan 31, 2011 at 10:53:00AM +0800, Amerigo Wang wrote:
    > > Our kdump script needs /sys/block/X/device/{vendor, model, type},
    > > but virtio devices don't have {model, type}, this patch adds them.
    > > Actually, I don't know how to fill the model field, other block devices
    > > seem read it from SCSI. Any comments?
    >
    > It does not make any sense to fill this at all in virtio. The
    > attributes are simply exporting the SCSI INQUIRY data, and do not make
    > any sense at all outside a SCSI context.
    > In fact the type field even
    > contains numbers from the scsi protocol spec that just don't make sense.

    ide seems to export these too.

    $ cat /sys/class/block/sr0/device/model
    DVDRAM GSA-U20N

    and I am pretty sure my dvd isn't scsi ...



    \
     
     \ /
      Last update: 2011-02-01 18:49    [W:0.023 / U:60.944 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site