Messages in this thread | | | From | Andres Salomon <> | Subject | Re: [PATCH] net: add Faraday FTMAC100 10/100 Ethernet driver | Date | Thu, 13 Jan 2011 08:29:50 -0800 |
| |
On Thu, 13 Jan 2011 15:22:39 +0100 Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le jeudi 13 janvier 2011 à 19:49 +0800, Po-Yu Chuang a écrit : > > From: Po-Yu Chuang <ratbert@faraday-tech.com> > > > > FTMAC100 Ethernet Media Access Controller supports 10/100 Mbps and > > MII. This driver has been working on some ARM/NDS32 SoC including > > Faraday A320 and Andes AG101. > > > > Signed-off-by: Po-Yu Chuang <ratbert@faraday-tech.com> > > --- > > drivers/net/Kconfig | 9 + > > drivers/net/Makefile | 1 + > > drivers/net/ftmac100.c | 1341 > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > drivers/net/ftmac100.h | 180 +++++++ 4 files changed, 1531 > > insertions(+), 0 deletions(-) create mode 100644 > > drivers/net/ftmac100.c create mode 100644 drivers/net/ftmac100.h > > Hi > [...] > > 9) Instead of dev_info(&netdev->dev ...) , please consider > netdev_info() > >
No one else mentioned it, so I'll add:
Don't explicitly inline functions unless they're in a header, or you have a really good reason (and that reason should probably be described in a comment). Otherwise, just leave off the 'inline' keyword; the compiler is smart enough to decide whether a function should be inlined or not.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |