Messages in this thread | | | Subject | Re: [PATCH v2] net: add Faraday FTMAC100 10/100 Ethernet driver | From | Eric Dumazet <> | Date | Mon, 17 Jan 2011 19:21:02 +0100 |
| |
Le lundi 17 janvier 2011 à 17:21 +0800, Po-Yu Chuang a écrit :
> + > + spin_lock_irqsave(&priv->tx_lock, flags); > + ftmac100_txdes_set_skb(txdes, skb); > + ftmac100_txdes_set_dma_addr(txdes, map); > + > + ftmac100_txdes_set_first_segment(txdes); > + ftmac100_txdes_set_last_segment(txdes); > + ftmac100_txdes_set_txint(txdes); > + ftmac100_txdes_set_buffer_size(txdes, len); > +
I wonder if its not too expensive to read/modify/write txdes->txdes1
Maybe you should use a temporary u32 var and perform one final write on txdes->txdes1 (with the set_dma_own)
> + priv->tx_pending++; > + if (priv->tx_pending == TX_QUEUE_ENTRIES) { > + if (net_ratelimit()) > + netdev_info(netdev, "tx queue full\n"); > + > + netif_stop_queue(netdev); > + } > + > + /* start transmit */ > + ftmac100_txdes_set_dma_own(txdes);
txdes->txdes1 = txdes1;
BTW, shouldnt you use cpu_to_be32() or cpu_to_le32(), if this driver is multi platform ?
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |