[lkml]   [2011]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] net: add Faraday FTMAC100 10/100 Ethernet driver
On Wed, 2011-01-19 at 17:40 +0800, Po-Yu Chuang wrote:
> On Tue, Jan 18, 2011 at 1:19 AM, Joe Perches <> wrote:
> > on split long line indentation style
> > and long function declarations.
> > Most of drivers/net uses an alignment to open parenthesis
> > using maximal tabs and minimal necessary spaces instead of
> > an extra tabstop.
> Well, TBH, I don't like this style because if I changed the
> function name, the indentation might need to be adjusted.

No worries. That could happen using either style.

There's no required style so you can use what you are
most comfortable doing. It's not a big deal at all.

> Even worse, I got an infeasible case :-(
> static struct ftmac100_rxdes *ftmac100_rx_locate_first_segment(
> struct ftmac100 *priv)
> I know my function names are quite long, but I like them to be descriptive.
> Do you really insist on it?

Here's a common alternative style for this case:

static struct ftmac100_rxdes *
ftmac100_rx_locate_first_segment(struct ftmac100 *priv)

 \ /
  Last update: 2011-01-19 17:43    [W:0.081 / U:5.968 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site