Messages in this thread | | | From | Po-Yu Chuang <> | Date | Fri, 14 Jan 2011 14:44:03 +0800 | Subject | Re: [PATCH] net: add Faraday FTMAC100 10/100 Ethernet driver |
| |
Dear Andres,
On Fri, Jan 14, 2011 at 12:29 AM, Andres Salomon <dilinger@queued.net> wrote: > On Thu, 13 Jan 2011 15:22:39 +0100 > Eric Dumazet <eric.dumazet@gmail.com> wrote: >> Le jeudi 13 janvier 2011 à 19:49 +0800, Po-Yu Chuang a écrit :
> No one else mentioned it, so I'll add: > > Don't explicitly inline functions unless they're in a header, or you > have a really good reason (and that reason should probably be described > in a comment). Otherwise, just leave off the 'inline' keyword; the > compiler is smart enough to decide whether a function should be inlined > or not.
OK, fixed.
Thanks, Po-Yu Chuang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |