Messages in this thread | | | Date | Wed, 16 Jun 2010 00:01:15 -0700 | From | "Justin P. Mattock" <> | Subject | Re: [PATCH 0/5] Fix set but unused variable warnings |
| |
On 06/15/2010 10:52 PM, Julian Calaby wrote: > On Wed, Jun 16, 2010 at 15:33, Justin P. Mattock > <justinmattock@gmail.com> wrote: >> Here is another set of patches fixing some warning messages generated >> when building the kernel when using gcc 4.6.0. >> >> This set just focuses in on the variables warnings that are reported >> to be unused. Keep in mind there are still lots more warning messages >> that I'm seeing, and will try my hardest to see if I can come up with >> a fix, but if things become too difficult and so forth then a bug should >> be filled etc.. > > Given that patches 3, 4 and 5 seem to be a cases of missing error > handling, (3 and 4 in particular seem to be breaking things rather > than fixing them) in my humble opinion, I think this set needs some > work and discussion. >
alright..
> Justin, maybe you'd be better off posting the actual error messages > (split up by subsystem) and letting the lists discuss them, rather > than posting patches which are obviously wrong. (like the ones I've > pointed out) >
yeah I'm a newbie!! alright so just file bugs for all these then.
> I'm sure that everyone here is as committed as you are to eliminating > compile warnings and errors and, in my opinion, more good will come > from a healthy discussion of the warnings than maintainers NAKing your > patches out of hand. > > Thanks, >
NAKing is o.k. but having discussions is better..
Justin P. Mattock
| |