Messages in this thread | | | Subject | Re: [PATCH 5/5]scsi:hosts.c Fix warning: variable 'rval' set but not used | From | James Bottomley <> | Date | Wed, 16 Jun 2010 10:34:03 -0500 |
| |
On Tue, 2010-06-15 at 22:33 -0700, Justin P. Mattock wrote: > The below patch fixes a warning message generated by gcc 4.6.0 > CC drivers/scsi/hosts.o > drivers/scsi/hosts.c: In function 'scsi_host_alloc': > drivers/scsi/hosts.c:328:6: warning: variable 'rval' set but not used > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- > drivers/scsi/hosts.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c > index 6660fa9..00fd6a4 100644 > --- a/drivers/scsi/hosts.c > +++ b/drivers/scsi/hosts.c > @@ -325,7 +325,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) > { > struct Scsi_Host *shost; > gfp_t gfp_mask = GFP_KERNEL; > - int rval; > > if (sht->unchecked_isa_dma && privsize) > gfp_mask |= __GFP_DMA; > @@ -420,7 +419,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) > shost->ehandler = kthread_run(scsi_error_handler, shost, > "scsi_eh_%d", shost->host_no); > if (IS_ERR(shost->ehandler)) { > - rval = PTR_ERR(shost->ehandler); > goto fail_kfree; > }
For future reference, this is less stylistically acceptable C: you've reduced the if clause to a single statement, so the braces need removing.
However, I don't think we should be ignoring the fact that the eh thread failed to spawn, so I think some type of printed warning (giving the error code) would be a much more appropriate replacement.
James
| |