Messages in this thread | | | From | Julian Calaby <> | Date | Wed, 16 Jun 2010 15:42:02 +1000 | Subject | Re: [PATCH 3/5]pci:bus.c Fix variable 'retval' set but not used |
| |
On Wed, Jun 16, 2010 at 15:33, Justin P. Mattock <justinmattock@gmail.com> wrote: > The patch below fixes the warning message I am seeing with gcc 4.6.0 > CC drivers/pci/bus.o > drivers/pci/bus.c: In function 'pci_enable_bridges': > drivers/pci/bus.c:237:6: warning: variable 'retval' set but not used > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- > drivers/pci/bus.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c > index 628ea20..84bdb48 100644 > --- a/drivers/pci/bus.c > +++ b/drivers/pci/bus.c > @@ -234,12 +234,10 @@ void pci_bus_add_devices(const struct pci_bus *bus) > void pci_enable_bridges(struct pci_bus *bus) > { > struct pci_dev *dev; > - int retval; > > list_for_each_entry(dev, &bus->devices, bus_list) { > if (dev->subordinate) { > if (!pci_is_enabled(dev)) { > - retval = pci_enable_device(dev); > pci_set_master(dev); > } > pci_enable_bridges(dev->subordinate);
Er, this appears to be bogus: I'm only guessing, but I'd expect that the pci_enable_device() call is actually doing something useful, and removing it is going to break *something* - Have you booted a kernel with this code enabled and these patches applied?
As for this warning, I think that there is a better solution.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |