| Date | Wed, 16 Jun 2010 14:07:41 +0800 | From | Junchang Wang <> | Subject | Re: [PATCH 3/5]pci:bus.c Fix variable 'retval' set but not used |
| |
On Tue, Jun 15, 2010 at 10:33:52PM -0700, Justin P. Mattock wrote: >@@ -234,12 +234,10 @@ void pci_bus_add_devices(const struct pci_bus *bus) > void pci_enable_bridges(struct pci_bus *bus) > { > struct pci_dev *dev; >- int retval; > > list_for_each_entry(dev, &bus->devices, bus_list) { > if (dev->subordinate) { > if (!pci_is_enabled(dev)) { >- retval = pci_enable_device(dev); Hi Justin,
pci_enable_device initializes device before it's used by a driver.
I think you should add check instead of eliminating pci_enable_device.
For example, retval = pci_enable_device(dev); if (retval < 0) { goto handle_err; }
--Junchang
|