Messages in this thread | | | Subject | Re: oprofile + hibernation = badness | From | Andi Kleen <> | Date | Tue, 19 Aug 2008 15:18:25 +0200 |
| |
Johannes Weiner <hannes@saeurebad.de> writes: > > You probably misconfigured emacs then. I ran checkpatch over your patch > and don't see how and why emacs would add trailing whitespace after a > opening brace.
I don't know how, but it does. vim does too sometimes (I use both editors)
> > You can use this to be on the safe side: > > (add-hook 'before-save-hook 'delete-trailing-whitespace)
That drops it on all. This means when I edit something which already has trailing spaces then the diff is full of noise. That would be a cure far worse than the disease[1]
Ideal would be if git-commit dropped them on all new lines, similar to git-apply --whitespace=fix and quilt refresh, but it doesn't seem to know how.
But normally maintainers just set these options (at least I do and Andrew does too) so it doesn't really matter if the submitted patch has trailing spaces or not because they disappear on the way up.
And that said I refuse to write any more on this silly bike shed topic.
-Andi
[1] to be honest I'm not sure i are actually a disease since I don't know of any single problem they cause.
| |