Messages in this thread | | | From | Johannes Weiner <> | Subject | Re: oprofile + hibernation = badness | Date | Tue, 19 Aug 2008 14:56:37 +0200 |
| |
Andi Kleen <ak@linux.intel.com> writes:
> Ingo Molnar wrote: >> * Vegard Nossum <vegard.nossum@gmail.com> wrote: >> >>> This gets rid of the suspend warnings, so it looks to be a step in >>> the right direction! FWIW, you may add my Tested-by to the patch. >> >> i've queued it up in tip/x86/oprofile - thanks guys. > > I would have thought Robert would take them? He's oprofile > maintainer after all. > >> >> Andi, another issue: your patch had 5 spurious whitespace >> errors. This is a reoccuring, many years pattern of behavior from >> you and you need to fix your workflow to send less sloppy patches. > > Yes I forgot you define patch cleanness based on white space. > > Seriously, It's actually new -- i did this one in git directly instead of > quilt and git-commit doesn't seem to know how to drop them. In my older quilt > workflow they were always automatically dropped since many years. Both emacs > and vim add them and I don't plan to switch editors, sorry.
You probably misconfigured emacs then. I ran checkpatch over your patch and don't see how and why emacs would add trailing whitespace after a opening brace.
You can use this to be on the safe side:
(add-hook 'before-save-hook 'delete-trailing-whitespace)
Hannes
| |