| Date | Mon, 5 May 2008 07:06:46 -0400 | From | Christoph Hellwig <> | Subject | Re: [patch 12/15] vfs: create file_truncate() helper |
| |
On Mon, May 05, 2008 at 11:54:53AM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi <mszeredi@suse.cz> > > Clean up do_truncate() API: > > - create a new function file_truncate() > - remove the 'struct file *' argument from do_truncate()
file_truncate looks like a nice little cleanup, but please make sure to add a kerneldoc comment for every newly added global function.
I don't think there's a point to remove the file argument from do_truncate and add another helper.
|