lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 05/15] reiserfs: dont call notify_change
From: Miklos Szeredi <mszeredi@suse.cz>

Reiserfs calls notify_change() on it's private extended attribute
files to resize and change ownership of these files. Replace with
reiserfs_setattr().

This is equivalent, except that:

- i_alloc_sem locking is not performed around reiserfs_setattr() when
the size is changed
- security_inode_setattr() is not called before reiserfs_setattr()
- fsnotify_change() is not called after reiserfs_setattr()

None of the above is necessary, since the files are private to
reiserfs and inaccessible from userspace.

Also remove setting of ctime on the xattr files.

Based on patch by Jeff Mahoney.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Acked-by: Jeff Mahoney <jeffm@suse.de>
---
fs/reiserfs/xattr.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-2.6/fs/reiserfs/xattr.c
===================================================================
--- linux-2.6.orig/fs/reiserfs/xattr.c 2008-05-05 11:29:25.000000000 +0200
+++ linux-2.6/fs/reiserfs/xattr.c 2008-05-05 11:29:25.000000000 +0200
@@ -458,9 +458,9 @@ reiserfs_xattr_set(struct inode *inode,

/* Resize it so we're ok to write there */
newattrs.ia_size = buffer_size;
- newattrs.ia_valid = ATTR_SIZE | ATTR_CTIME;
+ newattrs.ia_valid = ATTR_SIZE;
mutex_lock_nested(&xinode->i_mutex, I_MUTEX_XATTR);
- err = notify_change(dentry, &newattrs);
+ err = reiserfs_setattr(dentry, &newattrs);
if (err)
goto out_filp;

@@ -810,7 +810,7 @@ reiserfs_chown_xattrs_filler(void *buf,
}

if (!S_ISDIR(xafile->d_inode->i_mode))
- err = notify_change(xafile, attrs);
+ err = reiserfs_setattr(xafile, attrs);
dput(xafile);

return err;
@@ -843,7 +843,7 @@ int reiserfs_chown_xattrs(struct inode *

lock_kernel();

- attrs->ia_valid &= (ATTR_UID | ATTR_GID | ATTR_CTIME);
+ attrs->ia_valid &= (ATTR_UID | ATTR_GID);
buf.xadir = dir;
buf.attrs = attrs;
buf.inode = inode;
@@ -854,7 +854,7 @@ int reiserfs_chown_xattrs(struct inode *
goto out_dir;
}

- err = notify_change(dir, attrs);
+ err = reiserfs_setattr(dir, attrs);
unlock_kernel();

out_dir:
--


\
 
 \ /
  Last update: 2008-05-05 11:59    [W:0.087 / U:2.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site