lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 15/15] vfs: splice remove_suid() cleanup
    On Mon, May 05, 2008 at 11:54:56AM +0200, Miklos Szeredi wrote:
    > From: Miklos Szeredi <mszeredi@suse.cz>
    >
    > generic_file_splice_write() duplicates remove_suid() just because it
    > doesn't hold i_mutex. But it grabs i_mutex inside splice_from_pipe()
    > anyway, so this is rather pointless.
    >
    > Move locking to generic_file_splice_write() and call remove_suid() and
    > __splice_from_pipe() instead.

    Looks good to me. I wonder whether we should kill splice_from_pipe
    entirely and always leave the locking to the caller.



    \
     
     \ /
      Last update: 2008-05-05 13:13    [W:0.019 / U:60.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site