Messages in this thread | | | Date | Mon, 27 Oct 2008 07:34:49 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 00/12] x86: Cleanup idt, gdt/ldt/tss structs |
| |
Ingo Molnar wrote: > > Small detail, the syntactic form you chose: > > + if (!cpu->arch.idt[num].p) > > is not very readable because it's not obvious at first sight that ".p" > intends to mean "present bit". If then idt[num].present would have > been the better choice - but it's even better to not do bitfields at > all but an idt_present(desc *) helper inline function. >
There is, however, some benefit to use the field names that are in the official documentation, which include P.
-hpa
| |