lkml.org 
[lkml]   [2008]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/12] x86: Add static initiazlier for descriptors
Joe Damato wrote:
> Add static initializer for LDT/GDT/TSS descriptors.
>
> Signed-off-by: Joe Damato <ice799@gmail.com>
> ---
> include/asm-x86/desc_defs.h | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-x86/desc_defs.h b/include/asm-x86/desc_defs.h
> index a1c6516..5119051 100644
> --- a/include/asm-x86/desc_defs.h
> +++ b/include/asm-x86/desc_defs.h
> @@ -91,6 +91,20 @@ typedef struct desc_struct tss_desc;
> , .dpl = (hi >> 13) & 3 \
> , .p = (hi >> 15) & 1 \
> , .base1 = (hi >> 16) & 0xffff }
> +#define __DESC_INITIALIZER(lo,hi) \
> + { .limit0 = lo & 0xffff \
> + , .base0 = (lo >> 16) & 0xffff \
> + , .base1 = hi & 0xff \
> + , .type = (hi >> 8) & 0xf \
> + , .s = (hi >> 12) & 1 \
> + , .dpl = (hi >> 13) & 3 \
> + , .p = (hi >> 15) & 1 \
> + , .limit = (hi >> 16) & 0xf \
> + , .avl = (hi >> 20) & 1 \
> + , .l = (hi >> 21) & 1 \
> + , .d = (hi >> 22) & 1 \
> + , .g = (hi >> 23) & 1 \
> + ,.base2 = (hi >> 24) & 0xf }
>

Reasonable as a transition, I guess, but it would be better to just make
the initializers pass in proper values. But I think it would be better
to implement this with a union rather than repacking the packed values.

J


\
 
 \ /
  Last update: 2008-10-29 14:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog