lkml.org 
[lkml]   [2008]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/12] x86: Cleanup idt, gdt/ldt/tss structs

* Willy Tarreau <w@1wt.eu> wrote:

> On Fri, Oct 24, 2008 at 08:15:20PM -0700, Joe Damato wrote:
> > Hi -
> >
> > This is my first submission to the kernel, so (beware!) please let me know if I can make any improvements on these patches.
>
> It looks like you provide one patch per file. You should group some
> of them together so that each patch does a functional change and
> everything still builds after incrementally applying that patch. The
> way you have splitted them will break builds if someone tries to
> build after patch 1 for instance.

yes, at every step the kernel is expected to build and boot fine.

Ingo


\
 
 \ /
  Last update: 2008-10-27 11:59    [W:0.224 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site