| Date | Mon, 04 Dec 2006 23:05:02 -0800 (PST) | Subject | Re: [PATCH 0/3] New firewire stack | From | David Miller <> |
| |
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Tue, 05 Dec 2006 16:42:42 +1100
> - It's horribly broken in at least two area : > > DO NOT USE BITFIELDS FOR DATA ON THE WIRE !!! > > and > > Where do you handle endianness ? (no need to shout for > that one). > > (Or in general, do not use bitfields period ....)
Yes, this is a show stopper, the endianness and word-size/endian testing should have been done before submission. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|