lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 0/3] New firewire stack
    From
    From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Date: Tue, 05 Dec 2006 16:42:42 +1100

    > - It's horribly broken in at least two area :
    >
    > DO NOT USE BITFIELDS FOR DATA ON THE WIRE !!!
    >
    > and
    >
    > Where do you handle endianness ? (no need to shout for
    > that one).
    >
    > (Or in general, do not use bitfields period ....)

    Yes, this is a show stopper, the endianness and
    word-size/endian testing should have been done before
    submission.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-12-05 08:07    [W:0.022 / U:30.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site