[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/3] New firewire stack
David Miller wrote:
> From: Benjamin Herrenschmidt <>
> Date: Tue, 05 Dec 2006 16:42:42 +1100
>> - It's horribly broken in at least two area :
>> and
>> Where do you handle endianness ? (no need to shout for
>> that one).
>> (Or in general, do not use bitfields period ....)
> Yes, this is a show stopper, the endianness and
> word-size/endian testing should have been done before
> submission.

I guess my mistake here was to present it as a patch submission. I
acknowledged in my cover letter that it wasn't feature complete and I'm not
pushing for inclusion just yet. I'm very much aware of the point that when
replacing a subsystem like this, the new code has to be as good as the old
code. In that respect, the patches I posted are lacking in other areas
(isochronous streaming is the big one) that will take more work to fix than
just making it work on big-endian and 64-bit architectures. It's still a work
in progress.

Having said that, I've been working on this for a while now, and I wanted to
announce the effort and open the discussion about replacing the old stack.
Something about "release early, release often"... :) Anyway, I've moved the
portability issues to the top of my list now.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-12-05 17:49    [W:0.073 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site