lkml.org 
[lkml]   [2006]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] New firewire stack
From
Date
On Tue, 2006-12-05 at 00:22 -0500, Kristian Høgsberg wrote:
> Hi,
>
> I'm announcing an alternative firewire stack that I've been working on
> the last few weeks. I'm aiming to implement feature parity with the
> current firewire stack, but not necessarily interface compatibility.
> For now, I have the low-level OHCI driver done, the mid-level
> transaction logic done, and the SBP-2 (storage) driver is basically
> done. What's missing is a streaming interface (in progress) to allow
> reception and transmission of isochronous data and a userspace
> interface for controlling devices (much like raw1394 or libusb for
> usb). I'm working out of this git repository:

A very very very quick look at the code shows that:

- It looks nice / clear
- It's horribly broken in at least two area :

DO NOT USE BITFIELDS FOR DATA ON THE WIRE !!!

and

Where do you handle endianness ? (no need to shout for
that one).

(Or in general, do not use bitfields period ....)

bitfields format is not guaranteed, and is not endian consistent.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-12-05 06:45    [W:0.124 / U:2.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site