Messages in this thread | | | Date | Mon, 9 Sep 2002 17:30:26 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [BK PATCH] USB changes for 2.5.34 |
| |
On Mon, 9 Sep 2002, Greg KH wrote: > > Sorry, Matt told me to add it, I didn't realize the background. Should > I leave it as show_trace(), or just remove it? Do you want me to send > you another changeset to put it back?
I've just excluded it, with a comment to never _ever_ kill the machine unless there is a major reason for it.
We might want to add some "weaker" form of BUG_ON() for sanity checks that aren't life-threatening (ie a "CHECK(a == b)" kind of debug facility) that would be prettier than doing printk's and show_trace(), and that would also be easier to disable for production kernels (not that I personally much believe in disabling debugging like that - if it really isn't needed it should be removed, not disabled).
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |