lkml.org 
[lkml]   [2002]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BK PATCH] USB changes for 2.5.34
    On Mon, Sep 09, 2002 at 05:17:40PM -0700, Linus Torvalds wrote:
    >
    > Greg, please don't do this
    >
    > > ChangeSet@1.614, 2002-09-05 08:33:20-07:00, greg@kroah.com
    > > USB: storage driver: replace show_trace() with BUG()
    >
    > that BUG() thing is _way_ out of line, and has killed a few of my machines
    > several times for no good reason. It actively hurts debuggability, because
    > the machine is totally dead after it, and the whole and ONLY point of
    > BUG() messages is to help debugging and make it clear that we can't handle
    > something.
    >
    > In this case, we _can_ handle it, and we're much better off with a machine
    > that works and that you can look up the messages with than killing it.
    >
    > Rule of thumb: BUG() is only good for something that never happens and
    > that we really have no other option for (ie state is so corrupt that
    > continuing is deadly).

    Sorry, Matt told me to add it, I didn't realize the background. Should
    I leave it as show_trace(), or just remove it? Do you want me to send
    you another changeset to put it back?

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:28    [W:0.040 / U:122.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site