Messages in this thread | | | Date | Tue, 10 Sep 2002 12:23:46 +0200 | From | Andries Brouwer <> | Subject | Re: [BK PATCH] USB changes for 2.5.34 |
| |
On Mon, Sep 09, 2002 at 05:19:45PM -0700, Greg KH wrote: > On Mon, Sep 09, 2002 at 05:17:40PM -0700, Linus Torvalds wrote:
> > Greg, please don't do this > > > > Rule of thumb: BUG() is only good for something that never happens > > Sorry, Matt told me to add it, I didn't realize the background. Should > I leave it as show_trace(), or just remove it? Do you want me to send > you another changeset to put it back?
There were a few BUG_ON calls in scsi_glue.c and in transport.c that killed machines. For transport.c my source has
if (len != srb->request_bufflen) { printk("USB transport.c: len=%d srb->request_bufflen=%d\n", len, srb->request_bufflen); #if 0 show_trace(NULL); #endif } (show_trace was not defined here; I think the call should be deleted).
With some luck Alan's fix means that the ones in usb_stor_abort_transport() and [us_]release() are not triggered anymore.
Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |