| Date | Fri, 2 Jun 2023 11:59:55 -0400 | From | Peter Xu <> | Subject | Re: [PATCH 10/12] selftests/mm: move uffd* routines from vm_util.c to uffd-common.c |
| |
On Thu, Jun 01, 2023 at 06:33:56PM -0700, John Hubbard wrote: > This is where they belong, and this makes it cleaner to apply a > follow-up fix to the uffd builds. > > Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Thanks for further looking into this.
I'm fine to move it over if you think proper, but just to mention I had those in vm_utils.h just because I left all uffd specific tests shared code in uffd-common.h, so my plan was uffd-common.h shouldn't be included in most test cases except uffd tests.
I'm not sure whether we can just make your next patch of "ifndef.." into vm_utils.h to avoid the movement, or is it a must?
Thanks,
-- Peter Xu
|