Messages in this thread | | | Date | Fri, 2 Jun 2023 15:24:41 -0700 | Subject | Re: [PATCH 11/12] selftests/mm: fix missing UFFDIO_CONTINUE_MODE_WP and similar build failures | From | John Hubbard <> |
| |
On 6/2/23 09:25, Muhammad Usama Anjum wrote: > On 6/2/23 6:33 AM, John Hubbard wrote: >> UFFDIO_CONTINUE_MODE_WP, UFFD_FEATURE_WP_UNPOPULATED, USERFAULTFD_IOC, >> and USERFAULTFD_IOC_NEW are needed lately, but they are not in my host >> (Arch Linux) distro's userfaultfd.h yet. So put them in here. > Selftests are never supposed to build with native header files. Build the
Ah yes, I remember that now. Of course, the problem is that few people know or remember that, and it's undocumented as well.
> headers in kernel source first. Then building the selftests picks up these > newly built headers by itself. The method to build header files has changed > to `make headers`. The following command builds the mm selftests > successfully every time for me. > > make headers && make -C tools/testing/selftests/mm > > Please let me know if this doesn't work for you. I'll try to reproduce and fix. >
Yes thanks. That's a pointer to a full solution, which needs to:
a) automatically invoke "make headers", at least for selftests/mm for now, and
b) Add something to perhaps Documentation/dev-tools/kselftest.rst to document this requirement.
I'll work on that.
thanks, -- John Hubbard NVIDIA
| |