lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/12] selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h
    Date
    This fixes a real bug, too, because xstate_size()  was assuming that
    the stack variable xstate_size was initialized to zero. That's not
    guaranteed nor even especially likely.

    Signed-off-by: John Hubbard <jhubbard@nvidia.com>
    ---
    tools/testing/selftests/mm/pkey-x86.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/mm/pkey-x86.h b/tools/testing/selftests/mm/pkey-x86.h
    index 72c14cd3ddc7..e32ae8a1cd99 100644
    --- a/tools/testing/selftests/mm/pkey-x86.h
    +++ b/tools/testing/selftests/mm/pkey-x86.h
    @@ -132,7 +132,7 @@ int pkey_reg_xstate_offset(void)
    unsigned int ecx;
    unsigned int edx;
    int xstate_offset;
    - int xstate_size;
    + int xstate_size = 0;
    unsigned long XSTATE_CPUID = 0xd;
    int leaf;

    --
    2.40.1
    \
     
     \ /
      Last update: 2023-06-02 03:35    [W:2.942 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site