lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/12] selftests/mm: set -Wno-format-security to avoid uffd build warnings
    Date
    The uffd_test_start() is perhaps a little too elaborate about how it
    dispatches tests, leading to a clang warning that looks roughly like
    this:

    "uffd-unit-tests.c:1198:20: warning: format string is not a string literal
    (potentially insecure) [-Wformat-security] ...note: treat the string as
    an argument to avoid this.
    uffd_test_start(test_name);
    "

    However, it doesn't seem worth it to rewrite the way uffd_test_start()
    works, given that these tests are already deeply unsafe to begin with.

    Fix this by just disabling the compiler warning, but only for
    uffd-unit-tests.

    Signed-off-by: John Hubbard <jhubbard@nvidia.com>
    ---
    tools/testing/selftests/mm/Makefile | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
    index 23af4633f0f4..473bf1811552 100644
    --- a/tools/testing/selftests/mm/Makefile
    +++ b/tools/testing/selftests/mm/Makefile
    @@ -170,6 +170,8 @@ $(OUTPUT)/ksm_tests: LDLIBS += -lnuma

    $(OUTPUT)/migration: LDLIBS += -lnuma

    +$(OUTPUT)/uffd-unit-tests: CFLAGS += -Wno-format-security
    +
    local_config.mk local_config.h: check_config.sh
    /bin/sh ./check_config.sh $(CC)

    --
    2.40.1
    \
     
     \ /
      Last update: 2023-06-02 03:35    [W:2.184 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site