Messages in this thread | | | Date | Wed, 22 Mar 2023 16:51:00 +0100 | Subject | Re: [PATCH net 1/2] net: dsa: realtek: fix out-of-bounds access | From | Ahmad Fatoum <> |
| |
On 17.03.23 05:07, Jakub Kicinski wrote: > On Wed, 15 Mar 2023 14:09:15 +0100 Ahmad Fatoum wrote: >> - priv = devm_kzalloc(&mdiodev->dev, sizeof(*priv), GFP_KERNEL); >> + priv = devm_kzalloc(&mdiodev->dev, sizeof(*priv) + var->chip_data_sz, GFP_KERNEL); > > size_add() ? > Otherwise some static checker is going to soon send us a patch saying > this can overflow. Let's save ourselves the hassle.
The exact same line is already in realtek-smi. Would you prefer I send a follow-up patch for net-next which switches over both files to size_add or should I send a v2?
Cheers, Ahmad
>
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |