Messages in this thread Patch in this message | | | From | Ahmad Fatoum <> | Subject | [PATCH net 2/2] net: dsa: realtek: fix missing new lines in error messages | Date | Wed, 15 Mar 2023 14:09:16 +0100 |
| |
Some error messages lack a new line, add them.
Fixes: d40f607c181f ("net: dsa: realtek: rtl8365mb: add RTL8367S support") Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- drivers/net/dsa/realtek/rtl8365mb.c | 2 +- drivers/net/dsa/realtek/rtl8366-core.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index da31d8b839ac..33d28951f461 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -2068,7 +2068,7 @@ static int rtl8365mb_detect(struct realtek_priv *priv) if (!mb->chip_info) { dev_err(priv->dev, - "unrecognized switch (id=0x%04x, ver=0x%04x)", chip_id, + "unrecognized switch (id=0x%04x, ver=0x%04x)\n", chip_id, chip_ver); return -ENODEV; } diff --git a/drivers/net/dsa/realtek/rtl8366-core.c b/drivers/net/dsa/realtek/rtl8366-core.c index dc5f75be3017..f353483b281b 100644 --- a/drivers/net/dsa/realtek/rtl8366-core.c +++ b/drivers/net/dsa/realtek/rtl8366-core.c @@ -329,7 +329,7 @@ int rtl8366_vlan_add(struct dsa_switch *ds, int port, ret = rtl8366_set_vlan(priv, vlan->vid, member, untag, 0); if (ret) { - dev_err(priv->dev, "failed to set up VLAN %04x", vlan->vid); + dev_err(priv->dev, "failed to set up VLAN %04x\n", vlan->vid); return ret; } @@ -338,7 +338,7 @@ int rtl8366_vlan_add(struct dsa_switch *ds, int port, ret = rtl8366_set_pvid(priv, port, vlan->vid); if (ret) { - dev_err(priv->dev, "failed to set PVID on port %d to VLAN %04x", + dev_err(priv->dev, "failed to set PVID on port %d to VLAN %04x\n", port, vlan->vid); return ret; } -- 2.30.2
| |