Messages in this thread | | | Date | Wed, 15 Mar 2023 14:45:44 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net 1/2] net: dsa: realtek: fix out-of-bounds access |
| |
On Wed, Mar 15, 2023 at 02:35:34PM +0100, Ahmad Fatoum wrote: > Hello Andrew, > > On 15.03.23 14:30, Andrew Lunn wrote: > > On Wed, Mar 15, 2023 at 02:09:15PM +0100, Ahmad Fatoum wrote: > >> The probe function sets priv->chip_data to (void *)priv + sizeof(*priv) > >> with the expectation that priv has enough trailing space. > >> > >> However, only realtek-smi actually allocated this chip_data space. > >> Do likewise in realtek-mdio to fix out-of-bounds accesses. > > > > Hi Ahmad > > > > It is normal to include a patch 0/X which gives the big picture, what > > does this patch set do as a whole. > > > > Please try to remember this for the next set you post. > > Ok, will do next time. I didn't include one this time, because there's > no big picture here; Just two fixes for the same driver.
Fine. You could just say that. Patch 0/X is then used as the merge commit messages.
Andrew
| |