Messages in this thread | | | Date | Wed, 15 Mar 2023 14:35:34 +0100 | Subject | Re: [PATCH net 1/2] net: dsa: realtek: fix out-of-bounds access | From | Ahmad Fatoum <> |
| |
Hello Andrew,
On 15.03.23 14:30, Andrew Lunn wrote: > On Wed, Mar 15, 2023 at 02:09:15PM +0100, Ahmad Fatoum wrote: >> The probe function sets priv->chip_data to (void *)priv + sizeof(*priv) >> with the expectation that priv has enough trailing space. >> >> However, only realtek-smi actually allocated this chip_data space. >> Do likewise in realtek-mdio to fix out-of-bounds accesses. > > Hi Ahmad > > It is normal to include a patch 0/X which gives the big picture, what > does this patch set do as a whole. > > Please try to remember this for the next set you post.
Ok, will do next time. I didn't include one this time, because there's no big picture here; Just two fixes for the same driver.
Cheers, Ahmad
> > Andrew >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |