| Date | Sun, 12 Mar 2023 15:45:13 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH 27/28] media: i2c: max9286: drop of_match_ptr for ID table |
| |
Hi Krzysztof,
Thank you for the patch.
On Sun, Mar 12, 2023 at 02:13:17PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). This > also fixes !CONFIG_OF error: > > drivers/media/i2c/max9286.c:1707:34: error: ‘max9286_dt_ids’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> --- > drivers/media/i2c/max9286.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 701038d6d19b..ed932ff9ec74 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -1713,7 +1713,7 @@ MODULE_DEVICE_TABLE(of, max9286_dt_ids); > static struct i2c_driver max9286_i2c_driver = { > .driver = { > .name = "max9286", > - .of_match_table = of_match_ptr(max9286_dt_ids), > + .of_match_table = max9286_dt_ids, > }, > .probe_new = max9286_probe, > .remove = max9286_remove,
-- Regards,
Laurent Pinchart
|