lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table
    On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote:
    > The driver can match only via the DT table so the table should be always
    > used and the of_match_ptr does not have any sense (this also allows ACPI
    > matching via PRP0001, even though it might not be relevant here).
    >
    > drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=]
    >
    > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    Reviewed-by: Guenter Roeck <linux@roeck-us.net>

    FWIW: There is also
    https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@roeck-us.net/

    The lack of ACPI support is a real problem and very relevant.

    Guenter

    > ---
    > drivers/media/cec/i2c/ch7322.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/media/cec/i2c/ch7322.c b/drivers/media/cec/i2c/ch7322.c
    > index 34fad7123704..3c6e6496a001 100644
    > --- a/drivers/media/cec/i2c/ch7322.c
    > +++ b/drivers/media/cec/i2c/ch7322.c
    > @@ -589,7 +589,7 @@ MODULE_DEVICE_TABLE(of, ch7322_of_match);
    > static struct i2c_driver ch7322_i2c_driver = {
    > .driver = {
    > .name = "ch7322",
    > - .of_match_table = of_match_ptr(ch7322_of_match),
    > + .of_match_table = ch7322_of_match,
    > },
    > .probe_new = ch7322_probe,
    > .remove = ch7322_remove,

    \
     
     \ /
      Last update: 2023-03-27 00:57    [W:2.744 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site