Messages in this thread | | | Date | Tue, 14 Mar 2023 09:45:39 -0700 | Subject | Re: [PATCH 01/28] media: cec: ch7322: drop of_match_ptr for ID table | From | Guenter Roeck <> |
| |
On 3/14/23 09:32, Krzysztof Kozlowski wrote: > On 14/03/2023 09:34, Hans Verkuil wrote: >> On 13/03/2023 23:01, Guenter Roeck wrote: >>> On Sun, Mar 12, 2023 at 02:12:51PM +0100, Krzysztof Kozlowski wrote: >>>> The driver can match only via the DT table so the table should be always >>>> used and the of_match_ptr does not have any sense (this also allows ACPI >>>> matching via PRP0001, even though it might not be relevant here). >>>> >>>> drivers/media/cec/i2c/ch7322.c:583:34: error: ‘ch7322_of_match’ defined but not used [-Werror=unused-const-variable=] >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> Reviewed-by: Guenter Roeck <linux@roeck-us.net> >>> >>> FWIW: There is also >>> https://patches.linaro.org/project/linux-media/patch/20230215214724.3798917-1-linux@roeck-us.net/ >> >> I superseded that patch in patchwork in favor of this patch since this is part of >> a larger series. > > I am personally fan of FIFO, so Guenter's patch should go in. >
FWIW, I do not care either way, I just wanted to point out that this patch _is_ both relevant and needed, and that it (or, rather, the original version) has been reviewed and tested.
Thanks, Guenter
| |