lkml.org 
[lkml]   [2023]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 26/28] media: i2c: imx290: drop of_match_ptr for ID table
    Hi Krzysztof,

    Thank you for the patch.

    On Sun, Mar 12, 2023 at 02:13:16PM +0100, Krzysztof Kozlowski wrote:
    > The driver can match only via the DT table so the table should be always
    > used and the of_match_ptr does not have any sense (this also allows ACPI
    > matching via PRP0001, even though it might not be relevant here). This
    > also fixes !CONFIG_OF error:
    >
    > drivers/media/i2c/imx290.c:1354:34: error: ‘imx290_of_match’ defined but not used [-Werror=unused-const-variable=]
    >
    > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > drivers/media/i2c/imx290.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
    > index 49d6c8bdec41..3c9470fbfd53 100644
    > --- a/drivers/media/i2c/imx290.c
    > +++ b/drivers/media/i2c/imx290.c
    > @@ -1363,7 +1363,7 @@ static struct i2c_driver imx290_i2c_driver = {
    > .driver = {
    > .name = "imx290",
    > .pm = &imx290_pm_ops,
    > - .of_match_table = of_match_ptr(imx290_of_match),
    > + .of_match_table = imx290_of_match,
    > },
    > };
    >

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2023-03-27 00:55    [W:4.100 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site