| Date | Wed, 25 Nov 2020 13:42:57 +0900 | From | Benjamin Poirier <> | Subject | Re: [PATCH 127/141] staging: qlge: Fix fall-through warnings for Clang |
| |
On 2020-11-20 12:39 -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/staging/qlge/qlge_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index 27da386f9d87..c41b1373dcf8 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -1385,6 +1385,7 @@ static void ql_categorize_rx_err(struct ql_adapter *qdev, u8 rx_err, > break; > case IB_MAC_IOCB_RSP_ERR_CRC: > stats->rx_crc_err++; > + break; > default: > break; > }
In this instance, it think it would be more appropriate to remove the "default" case.
|