lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 015/141] netfilter: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple break statements instead of just
    letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    net/netfilter/nf_conntrack_proto_dccp.c | 1 +
    net/netfilter/nf_tables_api.c | 1 +
    net/netfilter/nft_ct.c | 1 +
    3 files changed, 3 insertions(+)

    diff --git a/net/netfilter/nf_conntrack_proto_dccp.c b/net/netfilter/nf_conntrack_proto_dccp.c
    index b3f4a334f9d7..94001eb51ffe 100644
    --- a/net/netfilter/nf_conntrack_proto_dccp.c
    +++ b/net/netfilter/nf_conntrack_proto_dccp.c
    @@ -397,6 +397,7 @@ dccp_new(struct nf_conn *ct, const struct sk_buff *skb,
    msg = "not picking up existing connection ";
    goto out_invalid;
    }
    + break;
    case CT_DCCP_REQUEST:
    break;
    case CT_DCCP_INVALID:
    diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
    index 0f58e98542be..78d0bbc8868c 100644
    --- a/net/netfilter/nf_tables_api.c
    +++ b/net/netfilter/nf_tables_api.c
    @@ -8342,6 +8342,7 @@ static int nf_tables_check_loops(const struct nft_ctx *ctx,
    data->verdict.chain);
    if (err < 0)
    return err;
    + break;
    default:
    break;
    }
    diff --git a/net/netfilter/nft_ct.c b/net/netfilter/nft_ct.c
    index 322bd674963e..fec68b75f39a 100644
    --- a/net/netfilter/nft_ct.c
    +++ b/net/netfilter/nft_ct.c
    @@ -530,6 +530,7 @@ static void __nft_ct_set_destroy(const struct nft_ctx *ctx, struct nft_ct *priv)
    case NFT_CT_ZONE:
    if (--nft_ct_pcpu_template_refcnt == 0)
    nft_ct_tmpl_put_pcpu();
    + break;
    #endif
    default:
    break;
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:39    [W:4.019 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site