lkml.org 
[lkml]   [2021]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 071/141] braille_console: Fix fall-through warnings for Clang
    From
    Date
    Hi all,

    Friendly ping: who can take this, please?

    Thanks
    --
    Gustavo

    On 11/20/20 12:34, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > by explicitly adding a break statement instead of letting the code fall
    > through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > drivers/accessibility/braille/braille_console.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
    > index 9861302cc7db..359bead4b280 100644
    > --- a/drivers/accessibility/braille/braille_console.c
    > +++ b/drivers/accessibility/braille/braille_console.c
    > @@ -246,6 +246,7 @@ static int keyboard_notifier_call(struct notifier_block *blk,
    > beep(440);
    > }
    > }
    > + break;
    > case KBD_UNBOUND_KEYCODE:
    > case KBD_UNICODE:
    > case KBD_KEYSYM:
    >

    \
     
     \ /
      Last update: 2021-04-20 22:38    [W:5.969 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site