lkml.org 
[lkml]   [2020]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 087/141] hwmon: (max6621) Fix fall-through warnings for Clang
    On Fri, Nov 20, 2020 at 12:36:09PM -0600, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > by explicitly adding a break statement instead of letting the code fall
    > through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

    Acked-by: Guenter Roeck <linux@roeck-us.net>

    > ---
    > drivers/hwmon/max6621.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/hwmon/max6621.c b/drivers/hwmon/max6621.c
    > index 367855d5edae..7821132e17fa 100644
    > --- a/drivers/hwmon/max6621.c
    > +++ b/drivers/hwmon/max6621.c
    > @@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,
    > default:
    > break;
    > }
    > -
    > + break;
    > default:
    > break;
    > }
    > --
    > 2.27.0
    >

    \
     
     \ /
      Last update: 2020-11-21 19:51    [W:2.360 / U:1.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site