lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1
Date


> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Sunday, August 13, 2017 3:28 AM
> To: Long Li <longli@microsoft.com>
> Cc: Steve French <sfrench@samba.org>; linux-cifs@vger.kernel.org; samba-
> technical@lists.samba.org; linux-kernel@vger.kernel.org; Long Li
> <longli@microsoft.com>
> Subject: Re: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1
>
> Hi Long,
>
> a few meta-comments:
>
> first the split into lots of tiny lists makes the series really hard to read, I'd split
> it into just a few:
>
> Patch 1: add the protocol constants
> Patch 2-n: core cifs modifcation required to implement SMBD Patch n+1:
> add the actual SMBD code Patch n+2..m: write up the core CIFS code to use
> it.
>
> stcond a lot of the code doesn't seem to follow the usual Linux style.
> It might be a good idea to run it through scripts/checkpach.pl and at least fix
> the errors it generates. The warnings are much more opinioned so feel free
> to ignore them if they sound odd for now.

Hi Christoph

Thank you for reviewing the patch set.

I'll address those comments and update the patches.

Long

\
 
 \ /
  Last update: 2017-08-14 19:04    [W:0.428 / U:30.860 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site