| Date | Sun, 13 Aug 2017 03:15:10 -0700 | From | Christoph Hellwig <> | Subject | Re: [[PATCH v1] 08/37] [CIFS] SMBD: Define packet format for SMBD data transfer message |
| |
> +// SMBD data transfer packet with payload [MS-SMBD] 2.2.3 > +struct smbd_data_transfer { > + __le16 credits_requested; > + __le16 credits_granted; > + __le16 flags; > + __le16 reserved; > + __le32 remaining_data_length; > + __le32 data_offset; > + __le32 data_length; > + __le32 padding; > + char buffer[0];
Please use the actually standardized [] syntax for variable sized arrays. Also normally this would be a __u8 to fit with the other types, but I haven't seen the usage yet.
> +} __packed;
The structure is natually packed already, no need to add the attribute.
|