lkml.org 
[lkml]   [2017]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [[PATCH v1] 04/37] [CIFS] SMBD: Define per-channel SMBD transport parameters and default values
    > +/*
    > + * Per RDMA transport connection parameters
    > + * as defined in [MS-SMBD] 3.1.1.1
    > + */
    > +static int receive_credit_max = 512;
    > +static int send_credit_target = 512;
    > +static int max_send_size = 8192;
    > +static int max_fragmented_recv_size = 1024*1024;
    > +static int max_receive_size = 8192;

    Are these protocol constants? If so please use either #defines
    or enums with upper case names for them.

    > +// maximum number of SGEs in a RDMA I/O

    Please always use /* ... */ style comments in the kernel.

    \
     
     \ /
      Last update: 2017-08-13 12:13    [W:2.962 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site