lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [[PATCH v1] 07/37] [CIFS] SMBD: Implement receive buffer for handling SMBD response
Date
> -----Original Message-----
> From: linux-cifs-owner@vger.kernel.org [mailto:linux-cifs-
> owner@vger.kernel.org] On Behalf Of Long Li
> Sent: Wednesday, August 2, 2017 4:10 PM
> To: Steve French <sfrench@samba.org>; linux-cifs@vger.kernel.org; samba-
> technical@lists.samba.org; linux-kernel@vger.kernel.org
> Cc: Long Li <longli@microsoft.com>
> Subject: [[PATCH v1] 07/37] [CIFS] SMBD: Implement receive buffer for
> handling SMBD response
>
> +/*
> + * Receive buffer operations.
> + * For each remote send, we need to post a receive. The receive buffers are
> + * pre-allocated in advance.
> + */

This approach appears to have been derived from the NFS/RDMA one.
The SMB protocol operates very differently! It is not a strict request/
response protocol. Many operations can become asynchronous by the
server choosing to make a STATUS_PENDING reply. A second reply then
comes later. The SMB2_CANCEL operation normally has no reply at all.
And callbacks for oplocks can occur at any time.

Even within a single request, many replies can be received. For example,
an SMB2_READ response which exceeds your negotiated receive size of
8192. These will be fragmented by SMB Direct into a "train" of multiple
messages, which will be logically reassembled by the receiver. Each of
them will consume a credit.

Thanks to SMB Direct crediting, the connection is not failing, but you are
undoubtedly spending a lot of time and ping-ponging to re-post receives
and allow the message trains to flow. And, because it's never one-to-one,
there are also unneeded receives posted before and after such exchanges.

You need to use SMB Direct crediting to post a more traffic-sensitive pool
of receives, and simply manage its depth when posting client requests.
As a start, I'd suggest simply choosing a constant number, approximately
whatever credit value you actually negotiate with the peer. Then, just
replenish (re-post) receive buffers as they are completed by the adapter.
You can get more sophisticated about this strategy later.

Tom.

> +static struct cifs_rdma_response* get_receive_buffer(struct cifs_rdma_info
> *info)
> +{
> + struct cifs_rdma_response *ret = NULL;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&info->receive_queue_lock, flags);
> + if (!list_empty(&info->receive_queue)) {
> + ret = list_first_entry(
> + &info->receive_queue,
> + struct cifs_rdma_response, list);
> + list_del(&ret->list);
> + info->count_receive_buffer--;
> + info->count_get_receive_buffer++;
> + }
> + spin_unlock_irqrestore(&info->receive_queue_lock, flags);
> +
> + return ret;
> +}
> +
> +static void put_receive_buffer(
> + struct cifs_rdma_info *info, struct cifs_rdma_response *response)
> +{
> + unsigned long flags;
> +
> + ib_dma_unmap_single(info->id->device, response->sge.addr,
> + response->sge.length, DMA_FROM_DEVICE);
> +
> + spin_lock_irqsave(&info->receive_queue_lock, flags);
> + list_add_tail(&response->list, &info->receive_queue);
> + info->count_receive_buffer++;
> + info->count_put_receive_buffer++;
> + spin_unlock_irqrestore(&info->receive_queue_lock, flags);
> +}
> +
> +static int allocate_receive_buffers(struct cifs_rdma_info *info, int num_buf)
> +{
> + int i;
> + struct cifs_rdma_response *response;
> +
> + INIT_LIST_HEAD(&info->receive_queue);
> + spin_lock_init(&info->receive_queue_lock);
> +
> + for (i=0; i<num_buf; i++) {
> + response = mempool_alloc(info->response_mempool, GFP_KERNEL);
> + if (!response)
> + goto allocate_failed;
> +
> + response->info = info;
> + list_add_tail(&response->list, &info->receive_queue);
> + info->count_receive_buffer++;
> + }
> +
> + return 0;
> +
> +allocate_failed:
> + while (!list_empty(&info->receive_queue)) {
> + response = list_first_entry(
> + &info->receive_queue,
> + struct cifs_rdma_response, list);
> + list_del(&response->list);
> + info->count_receive_buffer--;
> +
> + mempool_free(response, info->response_mempool);
> + }
> + return -ENOMEM;
> +}
> +
> +static void destroy_receive_buffers(struct cifs_rdma_info *info)
> +{
> + struct cifs_rdma_response *response;
> + while ((response = get_receive_buffer(info)))
> + mempool_free(response, info->response_mempool);
> +}
> +

\
 
 \ /
  Last update: 2017-08-14 22:10    [W:0.444 / U:0.992 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site