Messages in this thread | | | Subject | Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning | From | Joe Perches <> | Date | Wed, 24 Sep 2014 21:31:06 -0700 |
| |
On Wed, Sep 24, 2014 at 11:13:45PM -0400, Elshad Mustafayev wrote: > > Fixed a coding style issue. [] > > diff --git a/kernel/acct.c b/kernel/acct.c [] > > @@ -376,9 +376,8 @@ static comp2_t encode_comp2_t(u64 value) > > if (exp > MAXEXP2) { > > /* Overflow. Return largest representable number instead. */ > > return (1ul << (MANTSIZE2+EXPSIZE2-1)) - 1; > > - } else { > > - return (value & (MAXFRACT2>>1)) | (exp << (MANTSIZE2-1)); > > } > > + return (value & (MAXFRACT2>>1)) | (exp << (MANTSIZE2-1)); > > Just what makes the replacement easier to follow? > if (foo) > return bar; > else > return baz; > is no less idiomatic than > if (foo) > return bar; > return baz; > > Al, really annoyed by how the words "coding style issue" are getting used as > a magic incantation...
I agree.
I'll see about updating checkpatch to avoid warning on
if (foo) return bar; else return baz;
| |